search

webcompat / webcompat-reporter-extensions

Browser extensions to help report site compatibilty issues.
26 stars 21 forks source link

Fixes #104 Add npm package:opera script in package.json #110

Closed MynahMarie closed 6 years ago

MynahMarie commented 6 years ago

r? @miketaylr

In this PR I simply added a script for package:opera that copies exactly the script for package:chrome in package.json (and taking the opportunity to test my git workflow in the process 😄 )

issue #104

MynahMarie commented 6 years ago

r? @miketaylr

Simply changing the extension was throwing an error so now the script generates a .crx format but the file is renamed to a .nex afterwards... Tried the extension generated in the opera browser and it seems to work fine but I don't know if this is what u had in mind... Is there a tool that generates directly a .nex binary?

miketaylr commented 6 years ago

Simply changing the extension was throwing an error so now the script generates a .crx format but the file is renamed to a .nex afterwards... Tried the extension generated in the opera browser and it seems to work fine but I don't know if this is what u had in mind... Is there a tool that generates directly a .nex binary?

Thanks @MynahMarie, this looks great. (I'm not sure if there are any maintained tools to generate .nex...).

Can you make one more change? mv is not cross platform, but if we do shx mv everything will work as expected for people building on Windows.

https://github.com/shelljs/shx

Can you add that? Then we're good to merge.

MynahMarie commented 6 years ago

r? @miketaylr

Done! :)

miketaylr commented 6 years ago

(sorry for the delay, have been on PTO)