search

webcompat / webcompat-reporter-extensions

Browser extensions to help report site compatibilty issues.
26 stars 21 forks source link

Add i18n for name and description in manifest.json #117

Open laghee opened 6 years ago

laghee commented 6 years ago

Builds on Issue 91 support.

miketaylr commented 5 years ago

@mbuotidem maybe something you might be interested in?

mbuotidem commented 5 years ago

@miketaylr cool, I'm going to investigate issue 91 to get myself up to speed.

miketaylr commented 5 years ago

@laghee or I can help with any questions here -- there's not a lot of context in this issue. :)

mbuotidem commented 5 years ago

@laghee Looks like you've already set everything up nicely. To be sure I'm on the right track, I just need to add two entries to messages.json for name and description, and then update manifest.json, right?

laghee commented 5 years ago

@mbuotidem Yep! As I recall, that should be basically all there is to it. Let us know if you run into any problems with testing once you get things set up -- I remember it being kind of a pain (and I think they changed some things with locales in Firefox).

mbuotidem commented 5 years ago

@laghee will do. ran into issues getting setup on windows :( so I'll use a linux box at at school tomorrow.

laghee commented 5 years ago

@mbuotidem If you can file a bug with whatever errors or obstacles you were encountering with Windows, that would be great. :)