webcompat / webcompat-reporter-extensions

Browser extensions to help report site compatibilty issues.
26 stars 22 forks source link

Fixes #91. Add support for i18n. #118

Closed laghee closed 6 years ago

laghee commented 6 years ago

This is super bare bones, but I managed to test a version with an Italian resource folder as a temporary add-on and can confirm it works to change the context menu text. I left the name & description parts alone for now as

FYI: There was some testing hairiness in that all target language packs must be installed (see "Testing out your extension section"), which wasn't 100% clear from the documentation, but this may be simplified in a future FF version.

r? @miketaylr

laghee commented 6 years ago

You're right -- I actually squashed 3 commits into one, but it probably would have made more sense to divide it into discrete segments. (As it was, they were more like "do thing," "do other thing after realizing 1st thing was messed up," "oops, fix 2nd thing " :D -- but the point stands.) I'll keep that in mind going forward.