search

webcompat / webcompat-reporter-extensions

Browser extensions to help report site compatibilty issues.
26 stars 21 forks source link

Investigate if firefox-mobile can be using the shared manifest.json #120

Closed miketaylr closed 6 years ago

miketaylr commented 6 years ago

I totally don't remember if it's using it's own manifest.json is on purpose, or just something I forgot to do.

If it's possible, we should use the shared one. If not, we should leave a comment somewhere (maybe in the webpack config file).

laghee commented 6 years ago

Final Edit: (I swear.) I'm not sure where my head is today, but I came back from a break ... and using the shared manifest worked fine. 🙄 Sending the PR.

Edit 2: To summarize... There's a reason firefox-mobile has its own manifest.json to draw on -- the extension throws all the errors below if set to build with the shared manifest.json.

However, I don't see why the shared manifest couldn't be altered to leave out the context menu permissions &/or the default icon bits (whichever cause the issue) and then just add those things in with the individual config files (as is done now for the version & ids). It would still be repeating code segments between the three config files, but that's already a problem anyway. Plus, I believe that could actually be solved to some extent by using webpack-merge to consolidate the configs.

Edit 1: Oh, 💩 ... I think I know what the issue is. Somehow the fix to the problem I was having with Issue #91 didn't make it into my flurry of commits on PR #118. There are still block comments in the English messages.json. 😱 Will file new issue & fix!

Original comment: So... in the process of testing whether it would work to use the shared manifest basically as is, I've stumbled upon another potential problem. After encountering errors with the shared manifest version of the mobile extension, I find I can't even get the original extension to load on either Android 7.0 or 8.0 (at least not as an unsigned zip file, as laid out here).

I get a lovely pop-up error (the same one I get with the altered webpack config version) instead:

screenshot_20180522-143004

When I run it through Mozilla's add-on validator (which, I'm not sure, may not make sense for mobile?), it insists that the manifest.json has block comments that need to be removed:

screenshot 2018-05-22 14 49 27

Needless to say ... actually no block comments.

Not sure what's going on here, but I'll check the desktop Firefox extension as long as I'm at it.

miketaylr commented 6 years ago

Thanks for digging into this!