search

webcompat / webcompat-reporter-extensions

Browser extensions to help report site compatibilty issues.
26 stars 22 forks source link

Missing locales files in Chrome (maybe others) addon #129

Closed miketaylr closed 6 years ago

miketaylr commented 6 years ago

STR:

  1. npm run build:chrome
  2. try to load unpacked extension from chrome://extensions

Expected: it works

Actual: screen shot 2018-07-06 at 4 21 45 pm

I see that in fact the locales directory and files are missing from dist/chrome

laghee commented 6 years ago

Oh, dear. I guess this is why testing is essential! I'm looking at the webpack.config and it looks like... the _locale file doesn't even get touched? Can that be right? Oops. I imagine that needs to be in the copy-webpack-plugin and it just didn't get in. Not sure if that was before or after the consolidation, though. :woman_facepalming: