webcompat / webcompat-reporter-extensions

Browser extensions to help report site compatibilty issues.
26 stars 22 forks source link

Fixes #140 - Add GA source and campaign params when user opens new issue page #141

Closed miketaylr closed 5 years ago

miketaylr commented 5 years ago

r? @laghee

miketaylr commented 5 years ago
> webcompat-reporter-addon@0.5.1 test /home/travis/build/webcompat/webcompat-reporter-extensions
> intern
Error: Cannot find module 'node_modules/babel-register/lib/node.js' from '/home/travis/build/webcompat/webcompat-reporter-extensions'
  at Node.loadScript  <src/lib/executors/Node.ts:242:18>
  at <src/lib/executors/Executor.ts:930:53>
  at <src/lib/executors/Executor.ts:950:24>
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! webcompat-reporter-addon@0.5.1 test: `intern`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the webcompat-reporter-addon@0.5.1 test script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2018-12-18T21_54_32_196Z-debug.log
The command "npm run test" exited with 1.

wat

miketaylr commented 5 years ago

For me, locally:

> webcompat-reporter-addon@0.5.1 test /Users/mitaylor/dev/webcompat-reporter-extensions
> intern

DEBUG: Adding default 'node' environment
DEBUG: Using default loader
DEBUG: Loaded suites: ["tests/lib/helpers.js","tests/test-checkurl-import.js","tests/test-dist-output.js","tests/test-manifest.js"]
✓ node - isReportableURL module - isReportableURL imported successfully (0.001s)
✓ node - isReportableURL module - isReportableURL is a function (0s)
✓ node - isReportableURL module - calling isReportableURL does not throw an error (0.001s)
✓ node - isReportableURL module - calling isReportableURL with valid protocols will return true (0.001s)
✓ node - isReportableURL module - calling isReportableURL with invalid protocols will not return true (0s)
✓ node - dist output - has shared output (single files) (0s)
✓ node - dist output - has _locales directory with all l18n message files (0.001s)
✓ node - manifest.json creation - has shared keys (0.003s)
✓ node - manifest.json creation - has version number (0.001s)
✓ node - manifest.json creation - has application keys (0s)
TOTAL: tested 1 platforms, 10 passed, 0 failed
miketaylr commented 5 years ago

OK, that made the tests happier!

miketaylr commented 5 years ago

This is fine be me, as long as the extra newline/whitespace added to the URL after the src parameter by the template string isn't an issue.

good point! let me test...

miketaylr commented 5 years ago

🔥 screen shot 2018-12-20 at 1 23 15 pm

miketaylr commented 5 years ago

Removed the whitespace, gonna carry over r+ and land.