search

webcompat / webcompat-reporter-extensions

Browser extensions to help report site compatibilty issues.
26 stars 21 forks source link

Fixes #88: Add package:chrome script to package.json #98

Closed ncarbon closed 6 years ago

ncarbon commented 6 years ago

Fixes #88: Add package:chrome script to package.json.

ncarbon commented 6 years ago

I've made the changes and pushed them to my branch. Does github automatically detect them or do I have to create a new PR or modify this one somehow?

miketaylr commented 6 years ago

Does github automatically detect them or do I have to create a new PR or modify this one somehow?

GitHub does automatically detect that!

Here's what I see:

screen shot 2018-03-02 at 10 28 45 am

miketaylr commented 6 years ago

(there's a conflict now, because I just merged in #97, but i'll take care of it)

miketaylr commented 6 years ago

(also, there's a failure on travis, but let's just merge and i'll file a follow up bug because it just breaks eslint. 🤷‍♂️)

miketaylr commented 6 years ago

Thank you @ncarbon!

miketaylr commented 6 years ago

(also, there's a failure on travis, but let's just merge and i'll file a follow up bug because it just breaks eslint. 🤷‍♂️)

Oops, I was being careless when fixing the merge conflict. Fixed here: https://github.com/webcompat/webcompat-reporter-extensions/commit/6a01294e04eb12a7d74a316ef338b3467b158eb3