search

webcompat / webcompat.com

Source code for webcompat.com
https://webcompat.com
359 stars 191 forks source link

Remove support for X-Reported-With header #1254

Closed miketaylr closed 7 years ago

miketaylr commented 7 years ago

And only support a src= param, to make things simple. Before we can do this we need to update all the add-ons and get them published.

karlcow commented 7 years ago

How do we treat legacy? Aka add-on deployed in the wild but not updated.

karlcow commented 7 years ago

Also I guess this is linked to #1249 or am I confused X-Requested-With here in #1254 and X-Reported-With in #1249

miketaylr commented 7 years ago

How do we treat legacy? Aka add-on deployed in the wild but not updated.

So, it turns out I never published the addons that sent X-Reported-With -- I dropped the ball on that. I did just publish versions 0.5 of Firefox Desktop and Chrome that send &src=reporter-addon-chrome, etc. yesterday.

(Note: Opera Link isn't allowing me to login to their dev portal... which may be a sign that it's dead, or maybe just a temporary thing).

The odds that someone built the addon from the repo for the few weeks that code existed are probably low enough to not worry about.

(Also, I just keep mixing it up, it's actually just X-Reported-With)

miketaylr commented 7 years ago

Here's the relevant code to change: https://github.com/webcompat/webcompat.com/blob/274dc8c63aa506baceb235cfeb9ec26e1cdcb4b1/webcompat/views.py#L181

@zoepage lmk if you have any questions!

zoepage commented 7 years ago

Closed after PR merge: https://github.com/webcompat/webcompat.com/pull/1334