search

webcompat / webcompat.com

Source code for webcompat.com
https://webcompat.com
358 stars 191 forks source link

Label editor not working on Android 2.* #237

Closed tagawa closed 10 years ago

tagawa commented 10 years ago

How to reproduce:

  1. Go to http://webcompat.com and login
  2. Open an issue, e.g. http://webcompat.com/issues/22
  3. Click on the label editor cog icon above the comments.

What should happen: The label editor UI should appear.

What actually happens: The cog icon changes to a cross icon but that's all. The label editor doesn't appear.

miketaylr commented 10 years ago

Thanks @tagawa. I just deployed a fix to staging, can you test it? There's still an issue about scrollTop now working and some CSS overflow... but it's only in Android 2.3 and I don't really want to spend the entire day messing with such an old browser :( Any help here would be appreciated.

@magsout I went ahead and removed the JSON.parse and switched up the approach a little bit. Instead of sending a true or false for resizeLabelEditor via CSS, we only send "resizeEditor":true for the phone breakpont and then just check for resizeEditor via regex.

tagawa commented 10 years ago

Thanks @miketaylr. With a quick check it sort-of works. The scrollTo(0) is not working and only a screenfull (i.e. 480px equivalent) of the checkbox list is visible but it's better than before when nothing happened.

miketaylr commented 10 years ago

Yeah... I'm not quite sure what's up with the overflow or scrollTo. :/ Seems to work in all modern mobile browsers though.

tagawa commented 10 years ago

Android stock browser strikes again :-( I agree it's not worth spending days to make it perfect.

miketaylr commented 10 years ago

Thanks for verifying, let's close and I'll open a new issue for the viewport/scroll issues and slap a "help-wanted" label on it. Perhaps some smarter, kind soul will have mercy on us.