search

webcompat / webcompat.com

Source code for webcompat.com
https://webcompat.com
357 stars 191 forks source link

Validation of webcompat rendered HTML #2472

Open karlcow opened 6 years ago

karlcow commented 6 years ago

I was investigating something else and wanted to know if we had issues due to markup.

Steps to reproduce

  1. Generate a page
  2. View source
  3. Copy and paste into the text field of https://html5.validator.nu/

Enjoy!

Example. /issues/new route.

capture d ecran 2018-05-31 a 13 58 05
karlcow commented 6 years ago

Checking if I can fix most of them.

karlcow commented 6 years ago

/issues/new

capture d ecran 2018-05-31 a 14 51 13

Slightly better.

karlcow commented 6 years ago

Home page, not there yet.

capture d ecran 2018-05-31 a 14 56 26
karlcow commented 6 years ago

Example: https://github.com/webcompat/webcompat.com/blob/f42c9bcf4a1e54ac85f3ec3e38f215165927733d/webcompat/templates/home-page/how-it-works.html#L20

suhailsinghbains commented 6 years ago

Hi @karlcow is this bug still open? Would love to work on this.

karlcow commented 6 years ago

@suhailsinghbains yes. Thank you for proposing.

These are the 3 main categories of pages we can start with.

There is a lot of work to get it fixed and you will need to be careful with the rendering at each steps. There is a lot of dependencies in between the templates. They are located in webcompat/templates