webcompat / webcompat.com

Source code for webcompat.com
https://webcompat.com
360 stars 191 forks source link

The “fixme” label does not deactivate when another label from the same category is selected #2534

Open softvision-sergiulogigan opened 6 years ago

softvision-sergiulogigan commented 6 years ago

Steps to Reproduce:

  1. Navigate to https://webcompat.com/
  2. Click on “Report a bug” button.
  3. Fill in the required fields.
  4. Report the issue.
  5. Select a label from the "browser" category.
  6. Observe the “browser-fixme” label.

Expected Behavior: The “fixme” label is deactivated.

Actual Behavior: The “fixme” label is not deactivated.

Notes:

  1. Screen capture attached.
  2. See the behavior of "priority" labels.

Watchers: @softvision-sergiulogigan @softvision-oana-arbuzov

sv;

image

miketaylr commented 6 years ago

See the behavior of "priority" labels.

Ah, OK. Priority labels have special handling so you can only ever have one.

https://github.com/webcompat/webcompat.com/blob/cb766b2c2b7e628c9238195a71c28faaed6b349e/webcompat/static/js/lib/labels.js#L72-L78

It makes sense to extend this to fixme, I think. Once you selected another browser, make it be unchecked.

karlcow commented 6 years ago

Thanks @Obtin Please go ahead. Make sure to create test cases too so that we are sure to get the right behavior.

marimeireles commented 6 years ago

Hi @Obtin Are you still working on this? If not, I'm available and I'd like to take this issue Thanks! :)

marimeireles commented 6 years ago

Ok! I'm going to have a look at this.

sresthas commented 5 years ago

Hey, is this available? Can I take this up as my first issue?

karlcow commented 5 years ago

@twisted-sres sure if @marimeireles is not working on it and if it still reproduces.

marimeireles commented 5 years ago

I'm not. Sorry for that. Go ahead @twisted-sres. We have an IRC channel at mozilla called webcompat. The people in the team are all very nice and I'm sure they (and me included) will try to help you if you need! :) Feel free to join!