search

webcompat / webcompat.com

Source code for webcompat.com
https://webcompat.com
360 stars 191 forks source link

*.gif attachments are not displayed after bug submission #3048

Open softvision-sergiulogigan opened 5 years ago

softvision-sergiulogigan commented 5 years ago

Browser / Version: Firefox Nightly 72.0a1 (2019-10-24) Operating System: Windows 10 Pro

Steps to Reproduce:

  1. Navigate to https://staging.webcompat.com/issues/new
  2. Attach a gif file to the report.
  3. Send the report.

Expected Behavior: The *.gif file is displayed correctly.

Actual Behavior: The attachment is not displayed.

Notes:

  1. Screenshot attached.

Watchers: @softvision-sergiulogigan @softvision-oana-arbuzov @cipriansv

image

miketaylr commented 5 years ago

@softvision-sergiulogigan was it an animated gif by chance? Can you link to the issue you reported? Also curious if this is a difference in behavior from form v1. (You can test that on the home page / animated form thingy)

softvision-sergiulogigan commented 5 years ago

Hey @miketaylr

Can you link to the issue you reported?

yep... https://github.com/webcompat/webcompat-tests/issues/2017

and this is another one https://staging.webcompat.com/issues/2122 - new form https://staging.webcompat.com/issues/2123 - old form

Also curious if this is a difference in behavior from form v1. (You can test that on the home page / animated form thingy)

Looks like it's the same behavior on v1 as well... Also, the uploaded gifs are pretty badly broken. They don't animate as they should. This is the gif used to test. You can compare this to the ones uploaded in the other 2 reports (2122 and 2123)

Screen capture

miketaylr commented 5 years ago

Thanks. We have some issues with GIF. The issues related to gif quality are probably covered in

2785 and https://github.com/webcompat/webcompat.com/issues/2719#issuecomment-459218033

But not displaying a preview is not a known bug, I think. We could track that in this issue.