webcompat / webcompat.com

Source code for webcompat.com
https://webcompat.com
358 stars 191 forks source link

Fixes #3688 - Freeze Werkzeug version #3689

Closed ksy36 closed 2 years ago

ksy36 commented 2 years ago

There are some failing tests in CircleCI and I want to freeze Werkzeug version to 2.0.1 to fix them.

As we're not pinning Werkzeug version in requirements.txt, the most recent one is installed in CircleCI (2.1.0). In version 2.1.0, werkzeug has removed the as_tuple argument in the test client. Our current version of Flask is 2.0.1 still passes it, therefore the error is thrown. So freezing Werkzeug to 2.0.1 will address this.

https://flask.palletsprojects.com/en/2.1.x/changes/#version-2-1-0 The test client’s as_tuple parameter is removed. Use response.request.environ instead.

There is a separate issue for upgrading Flask to 2.1.1 (https://github.com/webcompat/webcompat.com/issues/3687), which requires additional testing as there are some failing tests. I want to deploy https://github.com/webcompat/webcompat.com/pull/3686 first, before updating Flask, in case something breaks :)

ksy36 commented 2 years ago

r? @karlcow