webcompat / webcompat.com

Source code for webcompat.com
https://webcompat.com
359 stars 191 forks source link

Update Intern to 3.4.0 #982

Closed miketaylr closed 7 years ago

miketaylr commented 8 years ago

The main reason I think we should do this is for the new bail option:

https://github.com/theintern/intern/commit/a6a732ef4864f23f68aee3bbb4ebb27c888f0992

What that means is if we hit a single test failure, Intern doesn't bother to run any more tests.

The latest release is 3.0.6: https://github.com/theintern/intern/releases/tag/3.0.6

So we'll probably want whatever comes next.

miketaylr commented 8 years ago

A few updates have been released, latest being https://github.com/theintern/intern/releases/tag/3.2.0

karlcow commented 7 years ago

ok thanks. Mike.

→ nvm current
v4.0.0

→ grunt
Running "checkDependencies:default" (checkDependencies) task
>> intern: installed: 2.2.0, expected: 3.4.0
>> Invoke npm install to install missing packages
Warning: Task "checkDependencies:default" failed. Use --force to continue.

Aborted due to warnings.

Let's give it a try

→ npm install
npm WARN deprecated minimatch@2.0.10: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
\
> intern@3.4.0 install /Users/karl/code/webcompat.com/node_modules/intern
> node support/fixdeps.js

intern@3.4.0 node_modules/intern
├── diff@1.1.0
├── platform@1.3.1
├── charm@0.2.0
├── mimetype@0.0.8
├── dojo@2.0.0-alpha.7
├── source-map@0.1.33 (amdefine@1.0.1)
├── glob@7.0.3 (path-is-absolute@1.0.1, inherits@2.0.3, once@1.4.0, inflight@1.0.6, minimatch@3.0.3)
├── chai@3.5.0 (assertion-error@1.0.2, type-detect@1.0.0, deep-eql@0.1.3)
├── leadfoot@1.7.0 (jszip@2.5.0)
├── digdug@1.6.2 (decompress@3.0.0)
├── lodash-amd@4.16.4
├── benchmark@2.1.1 (lodash@4.17.4)
└── istanbul@0.4.1 (abbrev@1.0.9, wordwrap@1.0.0, nopt@3.0.6, once@1.4.0, supports-color@3.2.3, which@1.2.12, async@1.5.2, mkdirp@0.5.1, esprima@2.7.3, fileset@0.2.1, resolve@1.1.7, js-yaml@3.8.1, escodegen@1.7.1, handlebars@4.0.6)

and then

→ grunt
Running "checkDependencies:default" (checkDependencies) task

Running "eslint:target" (eslint) task

Running "concat:dist" (concat) task
File "webcompat/static/js/webcompat.js" created.

Running "concat:diagnose" (concat) task
File "webcompat/static/js/diagnose.js" created.

Running "concat:issues" (concat) task
File "webcompat/static/js/issues.js" created.

Running "concat:issueList" (concat) task
File "webcompat/static/js/issue-list.js" created.

Running "concat:userActivity" (concat) task
File "webcompat/static/js/user-activity.js" created.

Running "concat:cssFixmeLibs" (concat) task
File "webcompat/static/js/cssfixme.js" created.

Running "uglify:dist" (uglify) task
File "webcompat/static/js/webcompat.min.js" created.

Running "uglify:issues" (uglify) task
File "webcompat/static/js/issues.min.js" created.

Running "uglify:issueList" (uglify) task
File "webcompat/static/js/issue-list.min.js" created.

Running "uglify:userActivity" (uglify) task
File "webcompat/static/js/user-activity.min.js" created.

Running "uglify:diagnose" (uglify) task
File "webcompat/static/js/diagnose.min.js" created.

Running "uglify:cssFixmeLibs" (uglify) task
File "webcompat/static/js/cssfixme.min.js" created.

Running "postcss:dist" (postcss) task

webcompat/static/css/development/main.css
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]
undefined [undefined]

>> 1 processed stylesheet created.

Running "cssmin:combine" (cssmin) task
File webcompat/static/css/webcompat.min.css created: 220.66 kB → 49.16 kB

Done, without errors.

Yeah!

miketaylr commented 7 years ago

@magsout do you know what's up with the wall of undefined [undefined]? That seems like a recent thing. Everything still works though, so I just ignore it.

magsout commented 7 years ago

@miketaylr Yes I saw that. I do not know where it comes from. I know it's from PostCSS and I think postcss-message. I would look to update. But as you said it has no impact. These are just messages in the console.