Closed alangdm closed 2 years ago
Name | Link |
---|---|
Latest commit | 50c798427688f7ee2e0e39b409882691371e4ab0 |
Latest deploy log | https://app.netlify.com/sites/web-components-cg/deploys/628daa3efdb31100082fc5ac |
Deploy Preview | https://deploy-preview-22--web-components-cg.netlify.app/articles/using/styling-shadow |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Looks like you made a good decision on the directory structure: https://deploy-preview-22--web-components-cg.netlify.app/articles/using/styling-shadow/. Do you want to get those "to dos" into this PR, or would it be better to take any high level notes on the content here, merge it in and then follow up on images/demos later?
I like the use of the webcomponents.dev demo, they do some embeds natively, right? Or I think @bennypowers did some MD plugins for similar. If that didn't work, we might look at leveraging features of the SSG we are using, e.g. https://rocket.modern-web.dev/docs/markdown-javascript/preview/, if for nothing else to colocate the demo to the documentation...
@Westbrook Thanks for checking the PR
As for the demo stuff, webcomponents.dev does have iframe embedding so I tried adding it for at least the last one. It looks pretty good to be honest.
I think using that or one of the plugins Benny made for using playground elements could look pretty good. If we do end up using wc dev I think it might be worth to create an org and one or multiple collections dedicated for the demos.
At any rate, the remaining TODOs I think can stay as they are for the time being until we sort out which option we want to use in a more general sense (I can remove the "comments") to make the article look a little nicer in its current form)
Some notes from the cg meeting:
I've updated the PR with the changes requested 👍
closes #19
Description
The article for the using web components styling section of the outline. Any feedback on the content/examples would be appreciated.
TBD