search

webcomponents / custom-elements-everywhere

Custom Element + Framework Interoperability Tests.
https://custom-elements-everywhere.com
Other
1.19k stars 103 forks source link

Which version of hyperHTML should we report? #177

Closed robdodson closed 6 years ago

robdodson commented 6 years ago

@WebReflection The site displays the library version under test:

image

However, with hyperhtml we're actually entirely using hyperhtml-element now, instead of hyperhtml itself. Would you rather show the hyperhtml version or the hyperhtml-element version?

WebReflection commented 6 years ago

Tests are using both HyperHTMLElement class and plain hyperHTML.

The fact HyperHTMLElement now ships with hyperHTML included is mostly webpack fault incapable of requiring properly ESM 😂

WebReflection commented 6 years ago

Btw, if you prefer showing HyperHTMLElement instead I’m fine with that. Your pick

robdodson commented 6 years ago

Tests are using both HyperHTMLElement class and plain hyperHTML.

oh yeah I guess that's true. I think what I ultimately want to point at is whatever version of hyperhtml is shipping with the version of hyperhtml-element that we use