search

webcomponents / custom-elements-everywhere

Custom Element + Framework Interoperability Tests.
https://custom-elements-everywhere.com
Other
1.18k stars 103 forks source link

Udating svelte version to 4.2.2 #2274

Closed OvidijusParsiunas closed 2 months ago

google-cla[bot] commented 11 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

OvidijusParsiunas commented 11 months ago

Svelte has recently published version 4.2.2 which fixes a camel case naming convention issue for properties. This PR version updates the Svelte version used within this repo to run the web component tests against it.

I am aware that there is another PR out there that updates some of Svelte tests, so if this PR overcomplicates things I am ok if it is declined.

nileshtrivedi commented 2 months ago

@rictic Could you please look at this PR to update the Svelte version and approve? If CLA is a problem, please consider approving https://github.com/webcomponents/custom-elements-everywhere/pull/2296

rictic commented 2 months ago

Sorry for the delay, this needed to update the expectations too. Fixed in #2369