webcomponents / custom-elements-everywhere

Custom Element + Framework Interoperability Tests.
https://custom-elements-everywhere.com
Other
1.16k stars 102 forks source link

Add Aurelia #50

Open 32graham opened 6 years ago

32graham commented 6 years ago

I've been successfully using Aurelia with custom elements for some time now. I would like to attempt a PR for adding Aurelia. Would that be something that is wanted?

robdodson commented 6 years ago

Absolutely!

On Thu, Sep 28, 2017, 6:12 AM Josh Graham notifications@github.com wrote:

I've been successfully using Aurelia http://aurelia.io/ with custom elements for some time now. I would like to attempt a PR for adding Aurelia. Would that be something that is wanted?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/webcomponents/custom-elements-everywhere/issues/50, or mute the thread https://github.com/notifications/unsubscribe-auth/ABBFDa1bKwCuh1CKpNFDJ5MHuxzMz1xqks5sm5sogaJpZM4PnPj7 .

enrico-padovani commented 6 years ago

Did someone start working on this? I might be available to help carrying this out.

32graham commented 6 years ago

@enrico-padovani I worked on it but was having trouble getting the Aurelia environment booted up correctly in the way that this project was wanting. I'll try to dig into my work tonight or tomorrow and remember what was causing me problems. I'll also push what I have to a public repository in case we want to collaborate.

32graham commented 6 years ago

Couldn't find my work from months ago. Got the skeleton set up again and pushed to a public repository ☝️. Will take another stab at getting Aurelia booted up correctly in this project some time over the next few days. Help welcomed.

enrico-padovani commented 6 years ago

@robdodson after npm run install-all I've npm run build-vue but I get the following error: 'run' 'test' 'DIST=../../docs/libraries/angular' Error: missing script: test;

I've noticed that package.json uses specific OS commands on build in order to create directory and copy files and I'm on Wondows 10. So I've installed those npm packages in order to get it work using node: cpr, mkdirp.

ORIGINAL "build": "npm run test; DIST=../../docs/libraries/vue && mkdir -p $DIST && cp -r ./meta $DIST/meta && cp -r ./results $DIST/results"

MODIFIED (does not pick up $DIST as variable and it creates a folder called $DIST under libraries/vue) "build": "npm run test && cross-env-shell DIST=../../docs/libraries/vue && mkdirp $DIST && cpr ./meta $DIST/meta --overwrite && cpr ./results $DIST/results --overwrite"

QUICK FIX (I've ended up repeating the path) "build": "npm run test && mkdirp ../../docs/libraries/vue && cpr ./meta ../../docs/libraries/vue/meta --overwrite && cpr ./results ../../docs/libraries/vue/results --overwrite"

With those fixes in every package.json I've got tests runinng (and writing results) for angualar, dojo2, hyperhtml, vue but I get errors from the others (test fails of course but got npm errors).

For example for Polymer:

HeadlessChrome 0.0.0 (Windows 10 0.0.0): Executed 15 of 15 (3 FAILED) (0.177 secs / 0.017 secs)

FirefoxHeadless: Executed 15 of 15 (3 FAILED) (0.198 secs / 0.033 secs)

TOTAL: 6 FAILED, 24 SUCCESS

when it ends throws an error (please see the attached file)

I've already spent a couple of hours on this, so I'd glad if someone can point me in the right direction.

32graham commented 6 years ago

@enrico-padovani I tried running from Windows and hit the same issues you were. If Windows support is needed, I suggest we log a separate bug.

Update on my progress: I've added code trying to get an Aurelia component booted up in the test environment but something in component.create(bootstrap) is never resolving. ¯_(ツ)_/¯

robdodson commented 6 years ago

ah yeah, someone filed an issue for windows support a while back: https://github.com/webcomponents/custom-elements-everywhere/pull/96

I've been meaning to take a second look at it, but don't have a windows machine handy to test on.