search

webcomponents / polyfills

Web Components Polyfills
BSD 3-Clause "New" or "Revised" License
1.13k stars 166 forks source link

fix(scoped-custom-element-registry): pass formAssociated to standInEl… #482

Closed calebdwilliams closed 2 years ago

calebdwilliams commented 2 years ago

Addresses #481. The catch here is that in order to work this changes the scoped custom element registry Closure compilation level to 'SIMPLE' which might cause extra bloat. There is probably a better way to do that, but I'm relatively unfamiliar with Closure Compiler.

Happy to update as needed or would accept changes to this PR from maintainers. This is a pretty huge blocker for me as I'm unable to implement form-associated custom elements and use the polyfill.

calebdwilliams commented 2 years ago

CLA signed, for what it's worth.

calebdwilliams commented 2 years ago

I made the requested changes, hopefully this commit will do it. Do you want me to rebase or is it fine having nine commits on this PR?