webcomponents / polyfills

Web Components Polyfills
BSD 3-Clause "New" or "Revised" License
1.13k stars 165 forks source link

[scoped-custom-element-registry] Add module flag to scoped-custom-element-registry #499

Open alangdm opened 2 years ago

alangdm commented 2 years ago

When trying to use @webcomponents/scoped-custom-element-registry through unpkg using the ?module flag, unpkg throws an error since the package doesn't include a module entry point

While removing the ?module flag in unpkg works when using this package directly, this is still a problem when using packages that depend on this package such as @open-wc/scoped-elements

I noticed that similar polyfills have solved this issue by adding a module entry point to the package.json so I tried doing the same

Please let me know if you would prefer the module entry point to be the unminified file instead

google-cla[bot] commented 2 years ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.