search

webcomponents / polyfills

Web Components Polyfills
BSD 3-Clause "New" or "Revised" License
1.13k stars 165 forks source link

fix(scoped-custom-elements-registry): return value from HTMLElement p… #537

Closed calebdwilliams closed 1 year ago

calebdwilliams commented 1 year ago

…rototype methods in polyfill

This fixes an issue where the scoped custom element registry polyfill fails to return the value of a polyfilled internals method.

michaelwarren1106 commented 1 year ago

this is a great change. In components where the scoped elements registry is used, if the value of those functions isn't returned, other mixins/polyfills like the element-internals-polyfill which also polyfills ElementInternals aspects won't be able to function properly.

justinfagnani commented 1 year ago

@calebdwilliams thanks! Any chance of adding a test for this?

justinfagnani commented 1 year ago

@calebdwilliams you need to update the CHANGELOG for scoped-custom-element-registry

calebdwilliams commented 1 year ago

Cool. I’ll take a crack at those tonight.

calebdwilliams commented 1 year ago

Updated the PR with a CHANGELOG entry and added a test.