Closed sjamesr closed 3 months ago
To clarify: In the description the phrase "with the fix the following error occurs" is saying that when closure-compiler is fixed it will report the error unless this PR is accepted first.
Please accept this PR to avoid having this error occur in your build.
I think a better title for this issue would be "Fix a type error that closure-compiler misses now, but will soon start reporting"
I'm trying to fix some bugs in the Closure compiler template type checker. The fix has revealed a type error in shadydom, which this PR attempts to fix.
With the fix, the following error occurs:
This error is correct because EventPatches is an object literal, which can never be an Event because Event is a nominal type in Closure.
I think this change should be OK and will unblock Closure compiler fixes.