search

webcomponents / webcomponents.github.io

WebComponents.org is where community-members document Web Components best practices
http://webcomponents.org
733 stars 126 forks source link

Add responsive menu #131

Closed filipelinhares closed 10 years ago

filipelinhares commented 10 years ago

Hi guys i did make a menu mobile like Zeno's blog (#112), i hope you enjoy.

screenshot_2014-07-08-07-06-11 screenshot_2014-07-08-07-06-03

sindresorhus commented 10 years ago

Nice! Can you make the links larger and with more line-height?

filipelinhares commented 10 years ago

Yes, i'm going to do it right now.

filipelinhares commented 10 years ago

Hey @sindresorhus, what do you think?

screenshot_2014-07-08-07-56-33

zenorocha commented 10 years ago

Hey @filipelinhares, thanks for submitting :)

I just left some source formatting comments. Try to follow the existing code style.

zenorocha commented 10 years ago

One more thing, <div class="menubutton"> should be an anchor <a class="menubutton"> with display: block and e.preventDefault().

zenorocha commented 10 years ago

And lastly, but not least. Can you make the following visual changes?

screen shot 2014-07-08 at 10 25 56 am

screen shot 2014-07-08 at 10 31 46 am

filipelinhares commented 10 years ago

@zenorocha yes :D

filipelinhares commented 10 years ago

@zenorocha here is!

screenshot_2014-07-08-13-30-04 screenshot_2014-07-08-13-29-54

zenorocha commented 10 years ago

Just started reviewing :)

:octocat: Sent from GH.

zenorocha commented 10 years ago

Thank you, pull request merged!

:octocat: Sent from GH.

zenorocha commented 10 years ago

Commits squashed and merged! :tada:

Thanks for contributing @filipelinhares :)