Closed zenorocha closed 9 years ago
:+1:
Left some comments but otherwise LGTM.
LGTM after the above comments are addressed.
O man, didn't realize it was going to be published as is. All the edits welcome!
Did an ammend commit for those minor reviews, now comments are gone - sorry about that =/
I'm glad we have history in email format :)
@addyosmani said:
Might be worth including an example here of how you're using the noscript tag for fallback. I've been doing similar and find it super useful!
@josh replied:
For the time element stuff, the inner "noscript" content is just a human readable date string.
One draw back here is that since the custom upgrade process is async, theres an noticeable FOUC when the plain text is converted to a relative date. The two texts often have different widths so it often affects line wrapping.
In other cases for select controls, maybe you'd do something like
<x-select> <select> <option ...> </select> </x-select>
Or even just use the is extension.
<select is="github-select"> <option ...> </select>
I'm really liking is as a way to extend existing controls. Typically we'd just do that with a custom class name, but the custom element lifecycle hooks are wonderfully useful.
So what do you think @josh, @robdodson, @addyosmani?