search

webcomponents / webcomponents.github.io

WebComponents.org is where community-members document Web Components best practices
http://webcomponents.org
734 stars 126 forks source link

Added Podcast Section #210

Closed Nevraeka closed 9 years ago

Nevraeka commented 9 years ago

Code

Nevraeka commented 9 years ago

Reverted a fix and replayed it with the correct ticket number.

zenorocha commented 9 years ago

Just started reviewing :)

:octocat: Sent from GH.

zenorocha commented 9 years ago

Hey @Nevraeka,

Good job on this PR, I know you put a lot of effort into it.

Here are some thoughts about it:

1) We need authorization from podcast owners to play their audios here;

Many of them depend on pageviews in their website to be sustained so they might not like if we just use their audio files.

2) MP3 isn't supported in all browsers;

Although MP3 is the most popular format for audio files, it's still not supported in many browsers.

3) Podcast name in Archive layout is differently styled from Single layout;

Archive layout (which is much bigger) screen shot 2015-02-02 at 11 15 59 pm

Single layout (which is the correct one) screen shot 2015-02-02 at 11 14 59 pm

4) Card title link points to a different path than "Read more" link;

Consistency matters.

5) Navbar size breaks search box position;

screen shot 2015-02-02 at 11 30 33 pm

Let me know if you have any questions.

Nevraeka commented 9 years ago

I appreciate the criticism and I agree with you. Good points on the authorization piece, download tracking, and MP3 support. I'll remove the audio player and just have links as you originally suggested. I will also update the UI pieces ASAP - hopefully by tomorrow or Wednesday. Thanks @zenorocha

Nevraeka commented 9 years ago

working on this now

Nevraeka commented 9 years ago

@zenorocha - sorry that took so long. Please review when you can and let me know what you think. We should definitley do that search ticket before the meetups feature get pushed in

zenorocha commented 9 years ago

Just started reviewing :)

:octocat: Sent from GH.

Nevraeka commented 9 years ago

@zenorocha ->

Nevraeka commented 9 years ago

Due to some merge issues I see I am closing this & posting a new PR