webcreate / conveyor

Build and deploy tool for PHP projects
http://conveyordeploy.com
MIT License
11 stars 3 forks source link

removing .git after export task is critical on windows #11

Open pscheit opened 11 years ago

pscheit commented 11 years ago

unfortunately, when I have the tortoiseGit installed it uses a cache-service which can be really bitchy when you try to move or remove .git directories.

I would skip removing the .git directory in the export task on windows and just ignore the .git directory while copying

 - Executing task Webcreate\Conveyor\Task\ExportTask
   Exporting: 0%

  [Symfony\Component\Filesystem\Exception\IOException]
  Failed to remove file ./build/deploy/.git\objects\pack\pack-e316cbecef6f74284c19953a17a744293f17176c.pack

thank you so much for all your fixes. I could understand if you're not willing to support windows in conveyor. But if you want to, I'll report issues as much as i can ;)

fieg commented 11 years ago

Aren't the use of wrong directory separators the issue here?

pscheit commented 11 years ago

nope, thats fine on windows. Not fine but acceptable ;)