search

webcreate / conveyor

Build and deploy tool for PHP projects
http://conveyordeploy.com
MIT License
11 stars 3 forks source link

fix isNewline cannot be read from php 5.3 #6

Closed pscheit closed 11 years ago

pscheit commented 11 years ago

php 5.3 cannot access protected properties in closure thats why i get here:

PHP Fatal error:  Cannot access protected property Webcreate\Conveyor\Subscriber\BuilderSubscriber::$needsNewline in phar:///usr/local/sbin/conveyor.phar/src/Webcreate/Conveyor/Subscriber/BuilderSubscriber.php on line 72

You probably want a test for that, can you help me where to start?

fieg commented 11 years ago

Adding conveyor to Travis-ci yesterday I also noticed this. I decided to set the minimal PHP requirement to 5.4.

pscheit commented 11 years ago

oh okay. So far I have found 3-4 places where this might need to be fixed. (currently I'm hacking quickfixes into the code directory on a debian remote machine).

I would love to have 5.3 integrated because right now I would have no time to upgrade to 5.4 on my remote (i'm such a girl)

pscheit commented 11 years ago

okay got my stuff together and upgraded :)

fieg commented 11 years ago

Good job! :+1:

You made me reconsider the 5.4 requirement, perhaps it's not a bad idea to support 5.3 after all. So I might change this later on.

pscheit commented 11 years ago

I think you should make your mind up right now. Its okay to discard 5.3 (I think) because mainly conveyor should be used from a dev-machine and not a production machine. And dev machines should be 5.4. But If you decide to support 5.3. you would not have 1000 places where you used the closure variables wrong. That will be a pain to change later on :)