Closed schmod closed 3 years ago
Hey @schmod can you rebase and add your PR to https://github.com/bramski/angular-indexedDB
The project is being taken over there.
Is there a new "official" maintainer?
Nevermind. Just saw #36. Will clean up and issue a new PR sometime in the next few days.
Hi @schmod . There's been a moderate rewrite over at the new repo.
I'll take a look and compare to my own fork to see if there's anything missing. We've been using angular-indexeddb fairly extensively for an internal project, and would love to contribute anything relevant that we have.
Yeah I see you added this "spreadRequest" which turns cursor calls into multiple promises. This is actually handled by .notify now. So if you use .each or .eachBy you can use .notify to receive each item in succession as it's pulled from the DB or use the resolution for the entire result set.
This is a moderate refactor that does a few things to address #19:
IDBRequest
s are now proxied through an internal method calledpromiseRequest()
. This method attaches standard success/error handlers to each request, catches any exceptions, and returns a promise. Accordingly, all errors should now be handled, and all exceptions should be caught.$q.all
)$rootScope.apply()
are wrapped in a convenience method.