search

webcss / angular-indexedDB

An angularjs serviceprovider to utilize indexedDB with angular
149 stars 99 forks source link

QueryBuilder fix and feature #29

Open joeljeske opened 10 years ago

joeljeske commented 10 years ago

I fixed a bug in the each() method on the ObjectStore where only the first item can be accessed using the cursor approach. When using a cursor, the onsuccess function is called multiple times and cursor.continue() re-calls the method with the next value. Using $q.promise, the listener can only be called once with the first item. To continue to allow the caller to select with items to be added to the list, I added a $filter option when creating a QueryBuilder. This option allows the selection of a function to be called for each item in the cursor. It is called with one argument being the value (cursor.value), and if it returns truthy, the item is added to the result set which is eventually returns in the promise resolution. I don't know of another way to allow independent selection of values when using a promise and resolution.

In working further with your tool, I have found that the QueryBuilderDefaults are changed directly instead of being copied when make a new query. I have add a call to angular.extend({}, defaults) to correct this bug.

bramski commented 10 years ago

Hey @joeljeske Can you rebase and move your PR to https://github.com/bramski/angular-indexedDB

I'm taking over maintenance of this project.