search

webcss / angular-indexedDB

An angularjs serviceprovider to utilize indexedDB with angular
149 stars 99 forks source link

Only iterate over stores if stores exist #37

Open cdjackson opened 10 years ago

bramski commented 10 years ago

hey @cdjackson this project is moving. https://github.com/bramski/angular-indexedDB

Can you add your PR and issue there? Thanks.

cdjackson commented 10 years ago

Hi, I certainly can, but there’s an issue. As your repo is behind the original one that I forked, if I create a PR you’ll get all the updates as well. I don’t see this is a problem - I guess you want to start with the latest, but before I do I wanted to make sure this was ok. Otherwise I’d have to cherry pick or something…

Cheers Chris

On 4 Sep 2014, at 22:55, Bram Whillock notifications@github.com wrote:

hey @cdjackson this project is moving. https://github.com/bramski/angular-indexedDB

Can you add your PR and issue there? Thanks.

— Reply to this email directly or view it on GitHub.

corburn commented 10 years ago

@cdjackson the for loop will never run if storeNames is empty.

cdjackson commented 10 years ago

It's been a few weeks since I looked at this, but I don't think it was the forEach loop that caused the problem I think it was the transaction call. In any case, this DID cause an exception, and this DID fix it.