search

webdeck / homebridge-indigo

Homebridge Plugin for Indigo
Apache License 2.0
13 stars 6 forks source link

Consolidate Devices with identical hardware addresses #4

Open RossGGG opened 8 years ago

RossGGG commented 8 years ago

I added a configurable option (called "consolidateDevices" in config.json) to consolidate Indigo devices that share a device address into a single accessory with multiple services. An example of where this would be useful is for FanLinc devices: Indigo must report these as two separate devices (one to control the fan, and one to control the light) because of how it handles device type controls in its own GUI, however HomeKit supports having these controls listed under a single device which makes more sense since they are associated with one physical device in your home.

webdeck commented 8 years ago

Thanks for the PR.

I have some questions as to how this works with Siri. What name will the combined device have? How do you differentiate the Siri commands for turning on/off the light versus turning on/off the fan?

Thanks, -Mike

RossGGG commented 8 years ago

,Hey. No problem. I actually decided to set it up this way because I was testing the Insteon Hub Pro before switching over to Homebridge, and that is how it handled Fanlincs. The name of the combined device is just the name of the first device encountered by Homebridge while it is parsing the JSON data. Initially all services on the device also carry the device name. I can look at the code a little more and see if it might be possible to have the service names be unique from the get-go, but I don't believe the Insteon Hub Pro was able to do that either. Anyway, in a HomeKit app, such as the Insteon+ app, Home, or HomeKit Catalog, you can edit the individual service names to make them distinguishable by Siri. Here are examples of what that looks like in a couple of those apps:

Sent from my iPhone

On Feb 27, 2016, at 10:15 PM, Mike Riccio notifications@github.com wrote:

Thanks for the PR.

I have some questions as to how this works with Siri. What name will the combined device have? How do you differentiate the Siri commands for turning on/off the light versus turning on/off the fan?

Thanks, -Mike

— Reply to this email directly or view it on GitHub.

brendanjerwin commented 8 years ago

FWIW I'd like to have this functionality too. Although the Insteon Homekit bridge was mostly crap, I did like how the fan units were combined in Homekit.