search

webdev-20 / shorti-url-shortener

Url Shortener
http://shorti.onrender.com/
7 stars 18 forks source link

feat: custom short link (back-end) #33

Closed MaestroDagan closed 2 years ago

MaestroDagan commented 2 years ago

Task What is the task? Adding the possibility to write your own short link (for example with bit.lies: bit.ly/Riverz instead of bit.ly/HfDMoP).

More about the task (optional) I'm only planning to add this option server-side/back-end.

Alternatives you've considered (optional) A clear and concise description of any alternative solutions or features you've considered.

Additional context (optional) Add any other context or screenshots about the feature request here.

MaestroDagan commented 2 years ago

I'm going to do this btw.

MaestroDagan commented 2 years ago

idk how to assign, if anyone knows pls tell me

MaestroDagan commented 2 years ago

I don't know how to add labels either

cherylli commented 2 years ago

i assigned you. Can you tell me how you're going to implement this feature?

MaestroDagan commented 2 years ago

I didn't see your message, i've already opened the PR. Sorry for my silly mistakes, i'm still pretty new to this opensource thing, but I'll explain how i implemented the feature

MaestroDagan commented 2 years ago

If the short property in the request body exists the value of randomString will be that, otherwise it'll be a random string.

cherylli commented 2 years ago

thanks I've checked your pr and requested some changes. also could you please turn off your auto format for now? we will add prettier to standardize formatting soon

MaestroDagan commented 2 years ago

okay, thank you! And i'll turn my auto format off

MaestroDagan commented 2 years ago

do you also want me to try to change all the formatting my auto formatter has done back?