webdev-20 / shorti-url-shortener

Url Shortener
http://shorti.onrender.com/
7 stars 18 forks source link

add auth endpoints #98

Closed EleekaN closed 2 years ago

EleekaN commented 2 years ago

Summary

added specifications for two endpoints: /api/users/signup /api/users/login

EleekaN commented 2 years ago

HI @cherylli, I tried out those two endpoints in swagger editor. It was looking fine. Please review it. Thank you.

cherylli commented 2 years ago

Hi, thanks for doing this. It looks good but could you also add the response content like this please?

image

EleekaN commented 2 years ago

Sure, so you want these sample response for authorization endpoints, right?

cherylli commented 2 years ago

They need to match the code. The screenshot was an example. Thank you. 🙂

EleekaN commented 2 years ago

They need to match the code. The screenshot was an example. Thank you. 🙂

right... understood, thank you :-)

EleekaN commented 2 years ago

Trying to update the file here. Should I create a new PR?

cherylli commented 2 years ago

Trying to update the file here. Should I create a new PR?

@EleekaN no, you don't have to make a new pr, you can just push the new changes to the same branch and it will reflect in the old pr