search

webdevatlanta / GroupCollaborationTool

Tool to allow developers to collaborate on open source and private projects
https://groupcollaborationtool.web.app
1 stars 21 forks source link

Refactor: The 'drawerOpen' prop is an antipattern. #78

Closed abrie closed 1 year ago

abrie commented 4 years ago

The app has two render states; NavDrawer Open, and NavDrawer Closed. The state is communicated to components via a prop. Ideally this should be moved to a a context and have better inversion of control.

image
DanielJWagener commented 4 years ago

Would fixing this issue also fix all the components re-rendering every time the drawer opens or closes? I was playing around with the app just now, and the projects table's re-rendering is kinda glaring. I couldn't figure out how to fix it though-- that problem is defying my understanding of how hooks work.