webdevops / helm-charts

Helm charts for webdevops applications
Apache License 2.0
0 stars 14 forks source link

Make it possible to not create service accounts for charts #23

Closed kristinnSnow closed 1 year ago

kristinnSnow commented 1 year ago

What this PR does / why we need it

We want to be able to specify a service account to use that has already been created. This was already possible in the azure-loganalytics-exporter chart and support for this had already been added to the _helper.yaml files.

I am using managed identity on an AKS cluster to connect to Azure, we have a service account connected to an identity that we want to use, we can however not change the service account to an already existing one in the Helm chart.

Special notes for your reviewer

I've bumped the patch version of each chart since the change is mostly backwards compatible. If the user has explicitly changed the serviceAccountName to nil then there service account used changes from default to the fullname of the chart. But in this case Helm would have been trying to create a service account with the name default, which would not work.

Since this touches a lot of different charts I have not added the chart name to the PR title.

Checklist