webdevops / helm-charts

Helm charts for webdevops applications
Apache License 2.0
0 stars 14 forks source link

[azure-metrics-exporter]: fix broken servicemonitor.metricprobe.yaml #62

Closed x418 closed 2 weeks ago

x418 commented 2 months ago

What this PR does / why we need it

This fixes the invalid condition (to check for namespaceSelector) that prevents template from rendering.

i.e. When probes exist, the template no longer renders as shown below

Error: template: azure-metrics-exporter/templates/prometheus/servicemonitor.metricprobe.yaml:23:16: executing "azure-metrics-exporter/templates/prometheus/servicemonitor.metricprobe.yaml" at <.Values.prometheus.monitor.namespaceSelector>: nil pointer evaluating interface {}.prometheus

Which issue this PR fixes

Special notes for your reviewer

Checklist

ThomasMinor commented 2 months ago

This PR also seems to fix https://github.com/webdevops/helm-charts/issues/60

ThomasMinor commented 1 month ago

Is there any date planned for his to get integrated?

antonKirkPalark commented 1 month ago

@mblaschke approve pls