webdevops / vagrant-docker-vm

:computer: Development Vagrant VM with Docker, Samba and Mail sandbox (customizable)
https://webdevops.io/projects/vagrant-docker-vm/
MIT License
87 stars 28 forks source link

Vagrantfile: Inconsistency in code of providers #58

Closed elmar-hinz closed 9 years ago

elmar-hinz commented 9 years ago

Symbols:

line 171: config.vm.provider :virtualbox do |v|
line 223: config.vm.provider :parallels do |v|

Strings:

line 206:  ["vmware_fusion", "vmware_workstation"].each do |provider|

I guess it's just a question of style in this case. Symbols are usually preferred.

Why override in this case in contrast to the others? The variable is never used.

line 207  config.vm.provider provider do |v, override|
mblaschke commented 9 years ago

Thanks :)