search

webdjoe / pyvesync

pyvesync is a python library to manage Etekcity & Levoit smart devices
MIT License
170 stars 80 forks source link

github actions #164

Open cdnninja opened 1 year ago

cdnninja commented 1 year ago

Before I create some PRs thoughts on github actions to help automate releases?

Thinking roughly what I run for https://github.com/Hyundai-Kia-Connect/hyundai_kia_connect_api

So semantic versioning that auto uploads to pypi. I noticed a home assistant PR for a version not listed here so looks like things aren't fully in sync. Can also do dependabot etc.

webdjoe commented 1 year ago

Most of these checks are already done in azure pipelines - I have pytest, pylint, flake8 and mypy checks. I'm not a huge fan of pipelines but I hesitate to waste time changing when it does what it is supposed to do. Is there an additional check that you think should be added?

cdnninja commented 1 year ago

That is great to hear! Having it in github would show for all PRs but if you are the primary dev not much help on that.

The other item will be semantic releases to make sure this feedback is held in lockstep:

https://github.com/home-assistant/core/pull/83146