setEmail on null when using using guest checkout

webdna / commerce-admin-orders

Create a new commerce order from the admin

Other

9 stars 1 forks source link

setEmail on null when using using guest checkout #9

Closed nfourtythree closed 4 years ago

nfourtythree commented 4 years ago

https://github.com/KuriousAgency/commerce-admin-orders/blob/e9657a005a8430a81ba466f306c50b8990d5c583/src/controllers/OrdersController.php#L209

That line is the offending line, as basically the $order variable is null.

mcjackson18 commented 4 years ago

Hi @nfourtythree, a new order is created as soon as the "New Order" button is clicked, this is passed through to the orders/update-user action via the orderNumber param.

As a new order should always exist It would be good to understand why $order is coming back as null on line 209.

Is the error intermittent or shown for every new order?
Is this happening if you select an existing user instead of guest checkout

nfourtythree commented 4 years ago

Hey @mcjackson18

Will take another look and see if I cant create a reliable replication of the error for testing