search

webdna / commerce-braintree

Braintree gateway for Craft Commerce
Other
2 stars 10 forks source link

Commerce 2.2 adds new abstract methods to base gateway #17

Closed nicgordon closed 4 years ago

nicgordon commented 4 years ago

After updating to Craft Commerce 2.2 we are now receiving this error from this plugin:

Class kuriousagency\commerce\braintree\gateways\Gateway contains 3 abstract methods
and must therefore be declared abstract or implement the remaining methods
(craft\commerce\base\SubscriptionGatewayInterface::getHasBillingIssues, 
craft\commerce\base\SubscriptionGatewayInterface::getBillingIssueDescription, 
craft\commerce\base\SubscriptionGatewayInterface::getBillingIssueResolveFormHtml)

Looks like those methods just need to be implemented in your Gateway.

MichaelWheldon commented 4 years ago

Would be great to get this updated 🙏

panosdigital commented 4 years ago

Same here. We are experiencing the same problem after updating 

yii\base\ErrorException: Class kuriousagency\commerce\braintree\gateways\Gateway contains 3 abstract methods and must therefore be declared abstract or implement the remaining methods (craft\commerce\base\SubscriptionGatewayInterface::getHasBillingIssues, craft\commerce\base\SubscriptionGatewayInterface::getBillingIssueDescription, craft\commerce\base\SubscriptionGatewayInterface::getBillingIssueResolveFormHtml) in /path/to website/vendor/kuriousagency/commerce-braintree/src/gateways/Gateway.php:854
Stack trace:
#0 [internal function]: yii\base\ErrorHandler->handleFatalError()
#1 {main}
mcjackson18 commented 4 years ago

Fixed in version 2.2.5, thanks @nicgordon for the PR.

nicgordon commented 4 years ago

You're welcome!

nicgordon commented 4 years ago

Any ETA on that 2.2.5 release @mcjackson18?

mcjackson18 commented 4 years ago

@nicgordon released today