search

webdna / commerce-braintree

Braintree gateway for Craft Commerce
Other
2 stars 10 forks source link

Craft site locale `zh` results in drop-in ui not rending #33

Closed zackspear closed 2 years ago

zackspear commented 3 years ago

Setting a site in Craft to Chinese, locale zh, results in the Drop-in UI not rending.

French, German, & Spanish work just fine.

Here's a low level example of it working: https://codepen.io/zackspear/pen/JjbaYzV

mcjackson18 commented 2 years ago

Hi @zackspear, I'm unable to replicate this issue, setting the site language to zh displayed the Drop-in UI correctly (see screenshot). braintree-drop-in-ui-zh .

zackspear commented 2 years ago

Thanks for taking a look. No worries.

If I recall correctly I resorted to rolling my own Drop-in UI implementation in Vue.js which allowed me to drop the jQuery requirement. We'd been using Vue.js everywhere on the site except the payment page so this helped us clean things up dependency wise.