search

webdna / commerce-bulk-pricing

Other
2 stars 2 forks source link

Error cauing tax issues with line Items #10

Closed deanfields closed 2 years ago

deanfields commented 2 years ago

https://github.com/KuriousAgency/commerce-bulk-pricing/blob/fb397c230a45114ff205c07506eac7c610d681b5/src/adjusters/Tax.php#L187

This line is causing a bug where the tax isn't being discounted on each line, only removing the VAT off one line item.

Tested removing this line which seemed to fix the issue

terryupton commented 2 years ago

I am seeing this issue too. Can we get an official release that fixes this @samuelbirch ?

terryupton commented 2 years ago

Here are some screenshots to support this.

Screenshot 2022-04-14 at 10 53 29 Screenshot 2022-04-14 at 10 48 55
terryupton commented 2 years ago

https://github.com/KuriousAgency/commerce-bulk-pricing/blob/fb397c230a45114ff205c07506eac7c610d681b5/src/adjusters/Tax.php#L187

This line is causing a bug where the tax isn't being discounted on each line, only removing the VAT off one line item.

Tested removing this line which seemed to fix the issue

@deanfields has this continued to function ok since you updated this in November?

mcjackson18 commented 2 years ago

Hi @terryupton, @deanfields, the above change has been made in version 1.1.7.