search

webdna / commerce-bulk-pricing

Other
2 stars 2 forks source link

Cannot assign craft\elements\Address to property webdna\commerce\bulkpricing\adjusters\Tax #16

Closed john-henry closed 2 years ago

john-henry commented 2 years ago

Just installed latest on Craft Craft CMS 4.1.4.1 and Craft Commerce 4.1.x-dev

I have not added the field yet to any product and get this when viewing frontend

Cannot assign craft\elements\Address to property webdna\commerce\bulkpricing\adjusters\Tax::$_address of type ?craft\commerce\models\Address

Created field and added to Product layout and same error

Happens when I'm logged in

I am admin and have 3 addresses in my account

https://share.johnhenry.ie/mXuxGPZN

robzor commented 2 years ago

Ah I guess this is because address is now a native craft field/property as well as the user no longer being separate?

john-henry commented 2 years ago

Yeah likely. I'm available for testing anything you want as we are on same time zone

robzor commented 2 years ago

I'm just an interested third party but the guys at webdna are pretty responsive. I actually know you from the EE world, long time no see :)

john-henry commented 2 years ago

Ah yes of course! Electric Putty days. Feel so old :)

robzor commented 2 years ago

I wasn't experiencing this error but I realised I didn't have any addresses associated with users (still very early in development) and once I added some and tried to manipulate them (for instance, copy billing address to shipping address in an order) the error appears.

samuelbirch commented 2 years ago

Thanks @john-henry and @robzor , we'll get looking into this.

samuelbirch commented 2 years ago

v2.0.0-beta.3 should fix this.

robzor commented 2 years ago

Gotta love a one line fix! Thanks @samuelbirch for smashing these fixes out :)