search

webdna / commerce-currency-prices

Add a product price for each currency
Other
3 stars 5 forks source link

Plugin with bulk-pricing is causing problems with the cost #11

Closed dgtlcrftrs closed 3 years ago

dgtlcrftrs commented 4 years ago

When this plugin is enabled it causes the bulk pricing to not be set correctly but disabling sets the correct price

mcjackson18 commented 4 years ago

Hi @dgtlcrftrs this could be due to the order your plugins are installed. Please can you try uninstalling both currency prices and bulk pricing and then installing currency prices first and bulk pricing after.

dgtlcrftrs commented 4 years ago

@mcjackson18 Hi I have given this a try, and it didn't seem to do anything

dgtlcrftrs commented 4 years ago

@mcjackson18 I have tried completely removing these items and reinstalling them in the order suggested with no luck too.

I guess the currency pricing plugin needs to check if bulk-pricing is installed and if there is a field associated on the product which has a price that can be applied to the product.

Maybe instead of calling the same event in each plugin, (not ever tried it) but have a shared module that gets installed (like the way sprout suite does) which gets attached to the line item event. In that method, you could check if each of the plugins are installed, and if the product has any bulk fields that should apply instead of the currency one before calling the methods from each plugin that modifies the price? Just an idea off the top of my head

mcjackson18 commented 4 years ago

@dgtlcrftrs, I've tested again with both plugins (Bulk Pricing & Currency Prices) installed but can't replicate the issue.

Can I check, on your Bulking Pricing field do you have the option to enter a price for each payment currency you have setup:

Screenshot 2020-02-21 at 14 06 41

dgtlcrftrs commented 4 years ago

Yes I can set the prices on the bulk for each currency setup. I am also using it with 0 units and with a specific group if that at all helps with the testing

dgtlcrftrs commented 4 years ago

It's certainly seems to be running out of order because it puts the 'original price' as the bulk price in the backend and the currency price as the sale price.

mcjackson18 commented 4 years ago

The bulk pricing is being ignored when using 0 units. Please can you try changing the 0 unit qty to 1, going to a product and entering a 1 unit price for each currency.

dgtlcrftrs commented 4 years ago

Actually sorry made a mistake it does already seem to be set to 1, but I'll go back and re-save it with 1 and see if that makes a difference.

tested and didn't make a difference

mcjackson18 commented 4 years ago

@dgtlcrftrs the bulk pricing plugin was updated earlier this month, please can you test using the latest version to see if this resolves this issue.

dgtlcrftrs commented 4 years ago

@mcjackson18 I believe this is now working after doing the update