Currency error in orders

[palomamtnez]

Description

1. The main currency is set up as NZD, however, the grid shows orders that were paid in USD showing without the currency code.

2. Shipping is displaying in NZD when the order was paid in a different currency.

Examples 1.

2.

To Reproduce How, and what happened? As screenshots

Expected behavior

1. Show all orders in the grid with their respective currency codes.
2. Show shipping with their respective currency code.

Additional info

• Craft version: 3.5.16
• Commerce version: 3.2.14
• Commerce Currency Prices: 2.7.1
• PHP version: 7.3.26
• Database driver & version: MySQL 5.7.33
• Other Plugins & versions:

Stripe for Craft Commerce: 2.3.2.1 PayPal for Craft Commerce: 2.1.0.1

[onetdev]

Hi @palomamtnez,

So I've ran into the same issue as you did and here is what I found.

• This is the OrderAdjustment currency converter in Commerce (it doesn't pass the currency to formatter): craftcms/commerce/src/models/OrderAdjustment.php#L115
• This is how the Transaction looks like (when it has defined currency): craftcms/commerce/src/models/Transaction.php#L184
• If the currency is not defined it fallbacks to the base currency (this is just an example for how to configure CurrencyAttributeBehavior): craftcms/commerce/src/behaviors/CurrencyAttributeBehavior.php#L164

This issue will occure when craftcms\commerc\elements\Order->currency has different value other than what is set to base currency.

I think this is the intended behavior on Commerce side but still feels wrong:

This helped the transaction to remain valid when having same currency and payment currency but not the same as base currency:

use craft\commerce\events\TransactionEvent;
use craft\commerce\services\Transactions;

Event::on(Transactions::class, Transactions::EVENT_AFTER_CREATE_TRANSACTION, function (TransactionEvent $event) {
        $tx = &$event->transaction;
        if ($tx->currency !== $tx->paymentCurrency) { return; }
        $tx->paymentCurrency = $tx->currency;
        $tx->paymentAmount = $tx->amount;
        $tx->paymentRate = 1;
});

Do you have currency issue on the transaction tab?