search

webdna / commerce-currency-prices

Add a product price for each currency
Other
3 stars 5 forks source link

bug in shipping conditions, not getting shipping method #7

Closed boldenamsterdam closed 5 years ago

boldenamsterdam commented 5 years ago

Looks like we are dealing with a bug.

I'm not getting a shipping method for my current selected currency, but I'm above the minimum total order price of this currency and below the max total weight. It looks like it is now being validated on the currency with the highest total order price.

How to reproduce:

I have 3 currencies:

  1. Dollar
  2. Euro
  3. Pound Sterling

My shipping condition is: Minimum cart total order price

  1. Dollar - $45
  2. Euro - €40
  3. Pound - £40

Max weight

  1. 20 Kilograms

When I put a product in my cart with a value of £42 Pound I'm not getting a shipping method. When I add another product so my total cart amount is going to £46 Pound I'm now seeing a shipping method. So the highest amount in the wrong currency is causing the bug.

CraftCMS: 3.2.9 Commerce: 2.1.11 Commerce Currency Prices: >= 2.4.2

boldenamsterdam commented 5 years ago

It looks like it is now being validated on the currency with the highest total order price.

The above quote is not correct. Found out it is being validated on the default currency, which is dollar in our case and also the highest total order price.

boldenamsterdam commented 5 years ago

Hi @mcjackson18 @samuelbirch ,

Did you guys see our message, if so have you been able to investigate the above issue?

Please let us know if we can assist in something or if you need more info from us.

mcjackson18 commented 5 years ago

Hi @boldenamsterdam, leave this with us and we'll investigate as soon as we can.

mcjackson18 commented 5 years ago

@boldenamsterdam this is fixed in 2.5.2

boldenamsterdam commented 5 years ago

Hi @mcjackson18 ,

We haven't really been able to test the new versions. Because since the updates we are not able to see the shipping cost fields in all the currencies we have set.

I expected to see 3 fields: USD, EUR, Pound

Screenshot 2019-10-31 at 14 06 32

I do get an JS error in the console, maybe it's related to this.

Screenshot 2019-10-31 at 14 12 51

mcjackson18 commented 5 years ago

@boldenamsterdam this is now fixed in 2.5.5

boldenamsterdam commented 5 years ago

Hi @mcjackson18

Unfortunately we cannot get it to work, we've sent a screencast to your agency e-mail address.

mcjackson18 commented 5 years ago

Hi @boldenamsterdam, we've not received an email from you, please can you try sending the screencast again to support at kurious dot agency.