search

webdriverio-boneyard / wdio-allure-reporter

A WebdriverIO v4 plugin. Reporter that creates Allure Test Reports (http://allure.qatools.ru/)
MIT License
38 stars 48 forks source link

Fixed issue #139 and added tests. #146

Closed NaveenThiyagarajan closed 6 years ago

NaveenThiyagarajan commented 6 years ago

Fixed the issue and created a new feature file with two scenarios as part of unit testing. NOTE: Added a cucumberOpts failFast: true to reproduce this issue.

NaveenThiyagarajan commented 6 years ago

@BorisOsipov @christian-bromann I hope now we are all good for the Merge. Thanks for all your help ... P.S: This is my FIRST PR in my career. :)

christian-bromann commented 6 years ago

@NaveenThiyagarajan would you mind making the same PR in our v5 repo so this patch stays after people upgrade to v5?

christian-bromann commented 6 years ago

Released as v0.8.3

NaveenThiyagarajan commented 6 years ago

@NaveenThiyagarajan would you mind making the same PR in our v5 repo so this patch stays after people upgrade to v5?

Thanks for releasing ...

How i exactly i do that... Do i need to fork the complete wdio repo and make these changes on the wdio-allure-reporter package?

BorisOsipov commented 6 years ago

@NaveenThiyagarajan @christian-bromann Patch is not need. There is no such cucumber reporting feature in v5 reporter yet

BorisOsipov commented 6 years ago

P.S: This is my FIRST PR in my career. :)

That is nice! Keep it going! As you see it is not so hard to do :)