search

webdriverio-boneyard / wdio-cucumber-framework

A WebdriverIO v4 plugin. Adapter for Cucumber testing framework.
MIT License
77 stars 61 forks source link

Update to cucumber 4.1.0.0 #104

Closed mhoyer closed 6 years ago

mhoyer commented 6 years ago

This is a first attempt to support cucumber v4. I am still testing with our local wdio-cucumber test cases. Feel free to try it on yours as well.

Hopefully it fixes #95

jsf-clabot commented 6 years ago

CLA assistant check
All committers have signed the CLA.

christian-bromann commented 6 years ago

Awesome work @mhoyer , thanks so much ❤️

mhoyer commented 6 years ago

@christian-bromann, you're welcome. But again, test it carefully with existing cucumber projects and please review my changes. Maybe I've overlooked something.

christian-bromann commented 6 years ago

Changes look good. The test suite is pretty extensive so I am confident that this is good to go and can be released. I will bump the major version so it won't break anyones test unless someone intentionally updates the adapter.

mhoyer commented 6 years ago

Perfect. But also README.md needs a little massage I guess. 😏

christian-bromann commented 6 years ago

Good point. I will take care of this.

christian-bromann commented 6 years ago

Released as v2.0.0