webdriverio-boneyard / wdio-cucumber-framework

A WebdriverIO v4 plugin. Adapter for Cucumber testing framework.
MIT License
77 stars 61 forks source link

Add new orders Option #117

Closed swissmanu closed 6 years ago

swissmanu commented 6 years ago

cucumber@4.2.0 introduced a new order option. This change adds order to DEFAULT_OPS and should fix #116.

jsf-clabot commented 6 years ago

CLA assistant check
All committers have signed the CLA.

swissmanu commented 6 years ago

cannot reproduce the failing tests on my machine :( could you try to rerun the build?

BorisOsipov commented 6 years ago

reran

christian-bromann commented 6 years ago

I feel like someone already posted this issue:


     TypeError: Cannot read property 'split' of undefined
      at orderTestCases (node_modules/cucumber/src/cli/helpers.js:74:22)
      at Object.<anonymous> (node_modules/cucumber/src/cli/helpers.js:41:3)
      at next (native)
      at undefined.tryCatcher (node_modules/bluebird/js/release/util.js:16:23)
      at PromiseSpawn._promiseFulfilled (node_modules/bluebird/js/release/generators.js:97:49)
      at Promise._settlePromise (node_modules/bluebird/js/release/promise.js:574:26)
      at Promise._settlePromise0 (node_modules/bluebird/js/release/promise.js:614:10)
      at Promise._settlePromises (node_modules/bluebird/js/release/promise.js:693:18)
      at Async._drainQueue (node_modules/bluebird/js/release/async.js:133:16)
      at Async._drainQueues (node_modules/bluebird/js/release/async.js:143:10)
      at Immediate.Async.drainQueues (node_modules/bluebird/js/release/async.js:17:14)
Xotabu4 commented 6 years ago

Thanks for fix!

christian-bromann commented 6 years ago

@vladgolubev @Xotabu4 something is still wrong with the build

BorisOsipov commented 6 years ago

I've fixed tests. @swissmanu thank you for PR.

swissmanu commented 6 years ago

thx for revising my PR @BorisOsipov !

Xotabu4 commented 6 years ago

Hi, can we publish minor version bump to npm? I would love to remove my overrides in package-lock.json, and peoples are trying to apply my fix also.

christian-bromann commented 6 years ago

I can take care of this

christian-bromann commented 6 years ago

Released as 2.1.0