search

webdriverio-boneyard / wdio-cucumber-framework

A WebdriverIO v4 plugin. Adapter for Cucumber testing framework.
MIT License
77 stars 61 forks source link

Fix events order. #147

Closed imdmitrykravchenko closed 6 years ago

imdmitrykravchenko commented 6 years ago

Fixes https://github.com/webdriverio/wdio-cucumber-framework/issues/142

wswebcreation commented 6 years ago

Hi @imdmitrykravchenko

I've already checked it and it fixes the order, tnx for it!.

I do have a question about it, this PR doesn't fix the scenario name and step name when a scenario outline is used. It that on purpose, because that is also handled in issue https://github.com/webdriverio/wdio-cucumber-framework/issues/142

Again, thanks for this PR

imdmitrykravchenko commented 6 years ago

Hi @wswebcreation!

Yes, good point. I've updated PR to fix ScenarioOutline steps names issue. Thanks!

wswebcreation commented 6 years ago

Tnx

I'll check it tonight/this weekend. Will let you know.

Tnx for picking this up!

christian-bromann commented 6 years ago

As far as I can see this can be merged and released.

Got it 👍

wswebcreation commented 6 years ago

@christian-bromann

I thought you had weekend ;-). Tnx for the quick response

BorisOsipov commented 6 years ago

I've also checked it on my project. It works like a charm. Thanks @imdmitrykravchenko!